Title: [108293] trunk/Source/WebCore
- Revision
- 108293
- Author
- [email protected]
- Date
- 2012-02-20 19:48:59 -0800 (Mon, 20 Feb 2012)
Log Message
Default canvas backing store to be 1:1 with specified dimensions.
https://bugs.webkit.org/show_bug.cgi?id=78971
Reviewed by Adam Barth.
Although the canvas specification states that the backing image may
be larger than the user-specified dimensions, there are a number of
philip canvas tests that fail when the backing image data is not
1:1 with the specified canvas dimensions. These failures are
tracked in https://bugs.webkit.org/show_bug.cgi?id=73645
This change defaults the canvas backing store to be 1:1 with the
user-specified dimensions, while also providing an
ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
behaviour, so that the above bug may be more easily fixed.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108292 => 108293)
--- trunk/Source/WebCore/ChangeLog 2012-02-21 03:24:45 UTC (rev 108292)
+++ trunk/Source/WebCore/ChangeLog 2012-02-21 03:48:59 UTC (rev 108293)
@@ -1,3 +1,24 @@
+2012-02-20 John Knottenbelt <[email protected]>
+
+ Default canvas backing store to be 1:1 with specified dimensions.
+ https://bugs.webkit.org/show_bug.cgi?id=78971
+
+ Reviewed by Adam Barth.
+
+ Although the canvas specification states that the backing image may
+ be larger than the user-specified dimensions, there are a number of
+ philip canvas tests that fail when the backing image data is not
+ 1:1 with the specified canvas dimensions. These failures are
+ tracked in https://bugs.webkit.org/show_bug.cgi?id=73645
+
+ This change defaults the canvas backing store to be 1:1 with the
+ user-specified dimensions, while also providing an
+ ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
+ behaviour, so that the above bug may be more easily fixed.
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::HTMLCanvasElement):
+
2012-02-20 Mary Wu <[email protected]>
Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (108292 => 108293)
--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2012-02-21 03:24:45 UTC (rev 108292)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2012-02-21 03:48:59 UTC (rev 108293)
@@ -79,7 +79,12 @@
, m_size(DefaultWidth, DefaultHeight)
, m_rendererIsCanvas(false)
, m_ignoreReset(false)
+#if ENABLE(HIGH_DPI_CANVAS)
+ // FIXME: Make this the default once https://bugs.webkit.org/show_bug.cgi?id=73645 has been fixed.
, m_deviceScaleFactor(document->frame() ? document->frame()->page()->deviceScaleFactor() : 1)
+#else
+ , m_deviceScaleFactor(1)
+#endif
, m_originClean(true)
, m_hasCreatedImageBuffer(false)
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
