Title: [108305] trunk/Source/WebCore
- Revision
- 108305
- Author
- [email protected]
- Date
- 2012-02-20 22:23:57 -0800 (Mon, 20 Feb 2012)
Log Message
Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
https://bugs.webkit.org/show_bug.cgi?id=79064
Reviewed by Hajime Morita.
[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
But as far as I read the spec
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
is not yet initialized. In particular, there is no statement that says "null should
be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
Removing [TreatReturnedNullStringAsNull] does not change the current behavior.
Test: media/media-controller.html (No change in the test results.)
* html/HTMLMediaElement.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108304 => 108305)
--- trunk/Source/WebCore/ChangeLog 2012-02-21 06:17:40 UTC (rev 108304)
+++ trunk/Source/WebCore/ChangeLog 2012-02-21 06:23:57 UTC (rev 108305)
@@ -1,3 +1,23 @@
+2012-02-20 Kentaro Hara <[email protected]>
+
+ Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
+ https://bugs.webkit.org/show_bug.cgi?id=79064
+
+ Reviewed by Hajime Morita.
+
+ [TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
+ But as far as I read the spec
+ (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
+ there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
+ is not yet initialized. In particular, there is no statement that says "null should
+ be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
+ fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
+ Removing [TreatReturnedNullStringAsNull] does not change the current behavior.
+
+ Test: media/media-controller.html (No change in the test results.)
+
+ * html/HTMLMediaElement.idl:
+
2012-02-20 Hayato Ito <[email protected]>
Use InsertinonPoint instead of HTMLContentElement.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.idl (108304 => 108305)
--- trunk/Source/WebCore/html/HTMLMediaElement.idl 2012-02-21 06:17:40 UTC (rev 108304)
+++ trunk/Source/WebCore/html/HTMLMediaElement.idl 2012-02-21 06:23:57 UTC (rev 108305)
@@ -117,7 +117,7 @@
readonly attribute [V8EnabledAtRuntime=webkitVideoTrack] TextTrackList textTracks;
#endif
- attribute [Reflect, TreatNullAs=NullString, TreatReturnedNullStringAsNull] DOMString mediaGroup;
+ attribute [Reflect, TreatNullAs=NullString] DOMString mediaGroup;
attribute [CustomSetter] MediaController controller;
};
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
