Title: [108314] releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (108313 => 108314)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-02-21 07:45:54 UTC (rev 108313)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-02-21 07:46:43 UTC (rev 108314)
@@ -1,5 +1,18 @@
2012-02-20 Martin Robinson <[email protected]>
+ Fix GTK+ unit tests after r108278.
+
+ Reviewed by Alejandro G. Castro.
+
+ Now that WebCore is no longer stealing focus, we need to
+ adjust where we grab focus to ensure that it actually succeeds.
+
+ * tests/testcopyandpaste.c:
+ (map_event_cb): No longer grab focus here.
+ (runPasteTestCallback): Grabbing focus here seems to be late enough in the process.
+
+2012-02-20 Martin Robinson <[email protected]>
+
[GTK] Web content oftens steals focus from other widgets
https://bugs.webkit.org/show_bug.cgi?id=77791
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testcopyandpaste.c (108313 => 108314)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testcopyandpaste.c 2012-02-21 07:45:54 UTC (rev 108313)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testcopyandpaste.c 2012-02-21 07:46:43 UTC (rev 108314)
@@ -111,7 +111,6 @@
gboolean map_event_cb(GtkWidget *widget, GdkEvent* event, gpointer data)
{
- gtk_widget_grab_focus(widget);
CopyAndPasteFixture* fixture = (CopyAndPasteFixture*)data;
webkit_web_view_load_string(fixture->webView, fixture->info->page,
"text/html", "utf-8", "file://");
@@ -137,6 +136,8 @@
static CopyAndPasteFixture* currentFixture;
static JSValueRef runPasteTestCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
{
+ gtk_widget_grab_focus(GTK_WIDGET(currentFixture->webView));
+
// Simulate a paste keyboard sequence.
GdkEvent* event = gdk_event_new(GDK_KEY_PRESS);
event->key.keyval = gdk_unicode_to_keyval('v');
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
