Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 97e6ebdc6b257b12126bf535ec5b70508b30d688
https://github.com/WebKit/WebKit/commit/97e6ebdc6b257b12126bf535ec5b70508b30d688
Author: Amanda Falke <afa...@igalia.com>
Date: 2023-08-07 (Mon, 07 Aug 2023)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
M Tools/TestWebKitAPI/glib/TestExpectations.json
Log Message:
-----------
[GLib] Use correct number of webviews for
TestWebsiteData/handle-corrupted-local-storage
https://bugs.webkit.org/show_bug.cgi?id=259701
Reviewed by Carlos Garcia Campos.
We added a test for handling corrupted local storage when we added the
GLib feature in 259573@main a few months ago in January.
It seems that this test has never succeeded since introduced according to
WPE API test reports (`wk-bot-digest` for the last several thousand CI
runs including this commit 259573@main); note that for WPE the new GLib API
is running on the bots by default build per OptionsWPE.cmake
`SET_AND_EXPOSE_TO_BUILD(ENABLE_2022_GLIB_API ON)`.
Previously, this test did not work for the new `2022_GLIB_API`, presumably
because it used 2 different network sessions for the 2 webViews. That did
not work for the new GLib API; it only worked for the old GLib API.
`test->m_webview` (used for the first webView) uses `test->m_networkSession`
as its network session, whereas the web views created manually without
specifying a network session are going to get a default network session
(e.g. `Test::adoptView(...)`, which was used in the second webView in
this test).
This test is now fixed in the new GLib API by using our idiomatic test
patterns found in our other API tests wrt the new GLib API with
conditionally creating a webView for new API that uses `test->m_networkSession`
for the second webView in this test, hence assuring that it shares the
same network session as the _first_ webView for the new GLib API;
now the test runs in the new GLib API.
Similar work was done for Cocoa test coverage in 262161@main in February;
that PR was a followup to 259573@main.
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebViewHandleCorruptedLocalStorage): See above.
* Tools/TestWebKitAPI/glib/TestExpectations.json: remove WPE API failing
expectation for this test that was added in a meta-gardening bug
b/256557 a couple of months ago in May.
Canonical link: https://commits.webkit.org/266631@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
