On Thu, Mar 1, 2012 at 7:18 PM, Ojan Vafai <o...@chromium.org> wrote:
> I think my earlier testing was faulty. Now when I test case 2, I get > something comparable with and without the patch. If there is a regression, > it's below the noise. Running it through a profiler shows a negligible > amount of time in the new code. > > I had tried running it through Dromaeo first, but any performance impact > (if there is any) was well below the variance. I can take a stab at running > Peacekeeper and Acid3 tomorrow, but I don't have high hopes of getting > useful information out of them. > That sounds promising. Here's another idea. What if we added ASSERT_NOT_REACHED right before we add the node to m_nodesToKeepAlive. This assertion is hit whenever we destroy a node too early. That should help us identifying code where we're not using RefPtr properly while still preventing such code from introducing security bugs. - Ryosuke
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
