On Fri, Feb 1, 2013 at 10:39 AM, Ryosuke Niwa <rn...@webkit.org> wrote:
> On Thu, Jan 31, 2013 at 5:20 PM, Hajime Morrita <morr...@chromium.org>wrote: > >> The history aside, I think it makes sense to use the export macro >> specifically for Mac WebCore because >> >> - As Eric mentioned, Currently only Mac and Win WebCore do WebCore/WebKit >> separation. >> Other ports like GTK or Chromium build single "WebKit" library which >> has both WebCore and WebKit API included. >> So we need to care about only Mac and Win for now. >> >> - Mac WebKit has relatively comprehensive feature set. It covers most of >> possibly exported symbols. >> >> - The Windows toolchain allows us to use both export symbols list and >> source-level annotation (the macro). >> Thus on Windows, we could use the Mac-centered export macro *and* an >> export symbol list which covers Win-specific exports. >> >> This means that there are unused exports on Win build, but I believe it >> is very few considering that Mac/Win ports has >> similar feature set, which targets Safari on each platform. (This might >> be wrong assumption though - On Mac, there are >> many other WebKit embedder other than Safari.) >> >> One exception is symbols exported for WebCoreTesting. >> Fortunately, these symbols are exactly same across ports and we can use >> another macro like >> WEBCORE_TESTING_EXPORT for that. >> > > Doesn't GTK+ port also require symbol exports for WebKit2? In particular, > I thought all symbols used in Internals need to be exported there. > Ouch, I'm sorry for the unclear explanation. This is what I meant say as "one exception" above. WebCoreTesting includes Internals, which requires some exported symbols, which could be (IMO) covered by WEBCORE_TESTING_EXPORT or some separate macro. > - R. Niwa > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev