Vadim Lebedev wrote: > Ludovico Cavedon wrote: >> I noticed that the compilation of qutecom generates a lot of compiler >> warnings. Fixing these warnings could help in increasing the stability >> of the application. >> >> Here >> http://allievi.sssup.it/cavedon/warnings.patch.gz >> is a patch that removes most of the warnings under linux, by: > > [...] > > 1) Format: it would be much easier to review if it was split > per-module and posted as series of messages on the list (please take a > look here:
Here it the patchbomb, split per module. > http://www.selenic.com/mercurial/wiki/index.cgi/PatchbombExtension) > 2) There are several modules in the project which are used 'as is' as > provided by upstream projects (srtp, curl, oSip, portaudio) i > beleive we should not patch them directly (maybe you should submit these > patches to the concerned projects directly) Ok! I agree. I skipped the libosip2 and srtp modules. However I believe that we should move these modules into libs/3dparty and support for using them as system libraries (like for ffmpeg) Regards, Ludovico _______________________________________________ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
