On Sun, 20 Feb 2005, Hrvoje Niksic wrote: > >> > 1. I'd say that code like "if ( sizeof(number) == 8 )" should have > >> > been a compile-time #ifdef rather than a run-time decision. > >> > >> Where do you see such code? grep 'if.*sizeof' *.c doesn't seem to > >> show such examples. > > > > As I recall, it was in someone's suggested changes. Perhaps: > > > > http://software.lpetrov.net/wget-LFS/wget-LFS-20041113.patch > > Oh, OK. I thought you were referring to my LFS patch.
Actually "if (sizeof(number) == 8)" is much more readable than any preprocessor clutter and yields exactly the same. Maciej
