Thanks for the report and the (correct) analysis.  This patch fixes
the problem in the trunk.


2007-01-23  Hrvoje Niksic  <[EMAIL PROTECTED]>

        * cookies.c (parse_set_cookie): Would erroneously discard cookies
        with unparsable expiry time.

Index: src/cookies.c
===================================================================
--- src/cookies.c       (revision 2202)
+++ src/cookies.c       (working copy)
@@ -390,17 +390,16 @@
            {
              cookie->permanent = 1;
              cookie->expiry_time = expires;
+             /* According to netscape's specification, expiry time in
+                the past means that discarding of a matching cookie
+                is requested.  */
+             if (cookie->expiry_time < cookies_now)
+               cookie->discard_requested = 1;
            }
          else
            /* Error in expiration spec.  Assume default (cookie doesn't
               expire, but valid only for this session.)  */
            ;
-
-         /* According to netscape's specification, expiry time in the
-            past means that discarding of a matching cookie is
-            requested.  */
-         if (cookie->expiry_time < cookies_now)
-           cookie->discard_requested = 1;
        }
       else if (TOKEN_IS (name, "max-age"))
        {

Reply via email to