https://bugzilla.wikimedia.org/show_bug.cgi?id=42321

Markus Krötzsch <mar...@semantic-mediawiki.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|Unprioritized               |Normal
             Status|NEW                         |ASSIGNED
           Severity|normal                      |minor

--- Comment #3 from Markus Krötzsch <mar...@semantic-mediawiki.org> 2012-11-22 
08:45:55 UTC ---
Ok, confirmed. The reason is the stupid implementation of PHP's
array_diff_assoc. We use it for comparing two arrays that have entries of the
form "key => value" where value is another array and key is a hash that
uniquely identifies this array. We use array_diff_assoc since it compares keys
and we don't want PHP to compare the rest (we already ensured that this matches
if the keys match). PHP, however, compares both the keys and the values, but
does this by casting values to string first and then comparing the strings.
This leads to a notice in PHP >5.4.0. The result is correct for us, but we
should still use another method for computing the diff here.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to