On Thu, 11 Jan 2001, Shane Nifong wrote:
[...]
> defined(@array) is deprecated at /usr/local/bin/winemaker line 1883.

   This one surprises me. I don't have this warning here. Which version
of perl are you using (here I'm using 5.005_03) ?


>         (Maybe you should just omit the defined()?)

   Is this you saying this or perl?
   Well, I followed this advice as, at least in this case, it should
work.


[...]
> Can't use an undefined value as an ARRAY reference at
> /usr/local/bin/winemaker line 539.

   Ok. The problem is that in single target mode the main target was not
created properly. Try the attached patch (I'm sending it to wine-patches
too).

   Alternately you could use the '--interactive' option. I find it more
practical than the single -target option. And its huge advantage is
that you can also use it if you actually have more than one target and
want to specify custom options to each.


--
Francois Gouget         [EMAIL PROTECTED]        http://fgouget.free.fr/
                      Computers are like airconditioners
                They stop working properly if you open WINDOWS
Index: tools/winemaker
===================================================================
RCS file: /home/wine/wine/tools/winemaker,v
retrieving revision 1.14
diff -u -r1.14 winemaker
--- tools/winemaker     2001/01/10 22:43:21     1.14
+++ tools/winemaker     2001/01/11 08:35:36
@@ -881,16 +881,20 @@
 # Scan the source directories in search of things to build
 sub source_scan
 {
-  my $main_target=@{$main_project[$P_TARGETS]}[0];
-
   # If there's a single target then this is going to be the default target
   if (defined $opt_single_target) {
+    # Create the main target
+    my $main_target=[];
+    target_init($main_target);
     if ($opt_target_type == $TT_DLL) {
       @$main_target[$T_NAME]="lib$opt_single_target.so";
     } else {
       @$main_target[$T_NAME]="$opt_single_target";
     }
     @$main_target[$T_TYPE]=$opt_target_type;
+
+    # Add it to the list
+    push @{$main_project[$P_TARGETS]},$main_target;
   }
 
   # The main directory is always going to be there
@@ -1887,7 +1891,7 @@
   }
   # Add execute permission to configure for whoever has the right to read it
   my @st=stat("configure");
-  if (defined @st) {
+  if (@st) {
     my $mode=$st[2];
     $mode|=($mode & 0444) >>2;
     chmod($mode,"configure");

Reply via email to