-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: > - swapchain->swapchain_ops->swapchain_present(swapchain, > src_rect, dst_rect, dirty_region, flags); + > wined3d_cs_emit_present(swapchain->device->cs, swapchain, > src_rect, + dst_rect, dst_window_override, dirty_region, > flags); I think we should place comments like "This function is called through the command stream" for all functions that are called through the CS, similar to what we do for context activation.
Also note that swapchain_gl_present contains calls to wined3d_surface_blt and wined3d_device_clear that are going to cause problems with the multithreaded CS. I have patches to remove them, so feel free to ignore this problem for now. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRWaKAAoJEN0/YqbEcdMw9VgP/i2n/G2CHOA8XShC8CZnRzSq TNzbfIXwAQljQYtf66U98JmbMIoeS3SMPaJ4O1+mMiT062Udi3YddiTk2AVF9bi+ f6X4y9W8Q3jPolcuTxKpZ26/WFkViHtPEUtFaa5oBtksCNGZ0b3A4oK9zbrPBram EXwovsq649RqCoBf76aidtbypdkFKLfmC6P6KxtjB3C9cdKJ58kMD0YbVsua6zNc g8gUgExEQ0no9WEyWPtlN7PRf3tQlLtuUeqrRockqnK48cKbwk3VaEgfq8o6+INs EvgjoZvc2C/+YoEWUT+n7nCtIKo9IiMSG20Ey0sbmak/K/LrvZvsyHl78nQD4ss+ t5jRCS9QZs/VzJc0VakGsZARP9jGBvzapsrAcy6Ittu1d53fpji6ySwKeUrPKim+ wMtWGtu+q0FXtIRtgDYUOofd9b1o1sB3xPqUIpRm7+yBRpXiBvuGqbmbsa/14wBe vkI5b5S/djskw9M5bV1lAOCgGmo+zFIYyebxwvx8H+sqz4HmYql9uPLTOHqWvHtn J7iXcETOlcOrC+zOOT8nieR8YYuFcda51auvK5lnXtCTQvoQse5egV16x2hJkkjx Pujit58jX2/O0WS0hqR5oAfhYtPydqUf2BayXgkLUODiZa0z1UWD2eerlOvGSvcq AUs+vi2QpDjeWmQH37BZ =QcW+ -----END PGP SIGNATURE-----