> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44161 > > User: mmann > Date: 2012/07/31 10:19 AM > > Log: > update GMR-1 protocols display filers > > Directory: /trunk/epan/dissectors/ > Changes Path Action > +67 -67 packet-gmr1_bcch.c Modified > +14 -14 packet-gmr1_common.c Modified > +100 -100 packet-gmr1_rr.c Modified > > > Hi Michael,
What is the rationale for this change exactly? So as to please the check*.pl scripts? For me it made sense to split big protocols in various files while still having a common root for filters. Moreover the rename from gmr1.rr.* to gmr1_ccch.* does not seem valid to me as the corresponding fields can be received either on CCCH or DCCH channels (the protocol name gmr1_ccch does not seem well chosen and might be named gmr1_rr instead). Regards, Pascal.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
