Hi, Preliminary review comments you could address before making an MR:
- Recreate the files using the dissector boilerplate doc/packet-PROTOABBREV.c - Get rid of the header file - The PCAP doesn’t go into a commit, it has to got into either a protocol page on the wiki, or in Sample Captures on the wiki. You ca do that yourself. - Change commit message header to “ PLDM: Adding dissector for Base Specification”, according to https://wiki.wireshark.org/Development/SubmittingPatches#writing-a-good-commit-message <https://wiki.wireshark.org/Development/SubmittingPatches#writing-a-good-commit-message> - Get consistent value_string indentation - Module static variables do not work, in the face of multiple conversation dissections and/or with packet random access. - We do have BCD support for fields, see if that works. - dissect_base() needs to be static - dissector_add_uint("wtap_encap", 147, base_handle); looks suspicious, where’s 147 coming from. - No g_print() in the code Hope it helps. > On 27 Jul 2023, at 21:51, Riya Dixit <riyadixita...@gmail.com> wrote: > > Hi community, > I am new to Wireshark development. I am trying to upstream my dissector. The > code works fine but why is the CI failing for all packages ( window×64, macos > arm and Intel). It is only passing for Windows MinGw. How do I debug this? > This is the link to my CI - > https://gitlab.com/riyadixitagra/wireshark-pldm/-/pipelines/913244896 > <https://gitlab.com/riyadixitagra/wireshark-pldm/-/pipelines/913244896>
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
