Bugs item #1537004, was opened at 2006-08-08 14:28 Message generated for change (Settings changed) made by derekc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1537004&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: light Group: v3.0 >Status: Pending >Resolution: Fixed Priority: 5 Submitted By: Jean-Luc Brouillet (jeanlucb) Assigned to: Derek (derekc) Summary: light.exe requires NUMBER_OF_PROCESSORS to be set Initial Comment: If I don't set the environment variable NUMBER_OF_PROCESSORS, I get this error: light.exe : error LGHT0219 : The NUMBER_OF_PROCESSORS environment variable is set to an invalid value of ''. Could we default in this case to Environment.ProcessorCount or 1? This is in 3.0.1926 ---------------------------------------------------------------------- >Comment By: Derek (derekc) Date: 2006-08-10 11:55 Message: Logged In: YES user_id=518766 Fixed - thanks for the bug report. ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-08-09 11:18 Message: Logged In: YES user_id=518766 That environment variable is set by the system, which is why WiX relies upon it (it should always be set). However, it does seem reasonable to handle a scenario such as yours by not failing if its not set. For now, you'll have to workaround this by setting the variable - I'll add the fallback logic for the next release (probably out next week). The Environment.ProcessorCount is a great way to go when we switch over to .net 2.0 (we're still completely 1.1). That sounds a lot more robust. Until then, you have two methods to set the number of processors: the environment variable and a special command line option for light (-ct). It's a very good idea to let light know an accurate processor count because it will create cabinet files in multiple processes which may cut down your build times in half or more (depending upon how many processors you have and how many cab files you create). ---------------------------------------------------------------------- Comment By: Jean-Luc Brouillet (jeanlucb) Date: 2006-08-09 11:03 Message: Logged In: YES user_id=1571556 Derek, Thanks for looking into this. I'm using Windows XP Pro. To make consistent builds, our build system cleans up the environment; no stray defines on random machine to produce erratic results. It then sets the environment variables it needs: PATH, etc. With the previous version of light.exe we were using, we did not need to set NUMBER_OF_PROCESSORS. I'm curious, who sets this environment variable? A fall back of 1 would be fine. I don't know if Environment.ProcessorCount would return blank too. It would require .NET 2.0. Something like Win32's GetSystemInfo() would be useful. I'm impressed by how fast you're responding. Great job! ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-08-08 23:01 Message: Logged In: YES user_id=518766 As far as I know, that environment variable should always be set. I could definitely add some fallback logic but I'd like to understand why the variable isn't set for you. If you run cmd from Start->Run will it have the variable set? What version of Windows are you running? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1537004&group_id=105970 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
