Bugs item #1942991, was opened at 2008-04-15 06:36 Message generated for change (Settings changed) made by robmen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1942991&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: light Group: v3.0 >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: Mikael Borjesson (mikabo) >Assigned to: Fredrik Grohn (fregro) Summary: Invalid culture causes Light to crash Initial Comment: When excuting light.exe, the error message "Culture 'en' is a neutral culture. It cannot be used in formatting and parsing and therefore cannot be set as the thread's current culture." is returned. This is caused by a call to String.Format() where CultureInfo.CurrentUICulture is sent as the IFormatProvider. However, CultureInfo.CurrentUICulture can contain a neutral culture, which will cause an exception if used for numeric formatting. I think the correct call would be String.Format(CultureInfo.CurrentCulture, ...), since CultureInfo.CurrentCulture cannot contain a neutral culture. Searching through the source code I actually find a lot of places where CultureInfo.CurrentUICulture is used. They could all need a review. ---------------------------------------------------------------------- Comment By: Neil Sleightholm (nsleigh) Date: 2008-04-22 09:17 Message: Logged In: YES user_id=1521752 Originator: NO I have also seen this bug with candle, see 1948860. It is probably just shared code but I thought I'd mention it. ---------------------------------------------------------------------- Comment By: Thomas (mp3observer) Date: 2008-04-22 04:54 Message: Logged In: YES user_id=1164267 Originator: NO hi! i have installed the latest version today (http://wix.sourceforge.net/releases/3.0.4014.0/wix3.msi) on Visual Studio 2008 (english, on vista 64 en) When i create a default project, or when i compile my own installer file, i get always the error ------------------------------ Error 1 Culture 'en' is a neutral culture. It cannot be used in formatting and parsing and therefore cannot be set as the thread's current culture. light.exe ------------------------------------------- for me, thats a piority 1 bug, because i can't compile any files! ---------------------------------------------------------------------- Comment By: Mikael Borjesson (mikabo) Date: 2008-04-15 23:24 Message: Logged In: YES user_id=2063687 Originator: YES It is correct that this does not occur in 3.0.3907. In that version CultureInfo.InvariantCulture was used as the IFormatProvider in the call to String.Format(). The exception will occur in ConsoleMessageHandler in WConsole when executing GenerateMessageString(), but I see the same change has been done in more places. ---------------------------------------------------------------------- Comment By: Jeremiah Devine (masterhoth) Date: 2008-04-15 16:32 Message: Logged In: YES user_id=98139 Originator: NO This error also occurs using light. I was able to produce this problem by using heat to create a package that contained the Java JRE 1.6_04 and then when using it with candle (after a tiny bit of manipulation for package name and path names via sed script) I received the en is a neutral culture error and candle crashed as well. This only occurs when using Wix 3.0.4014. In order to work around this I have downgraded to 3.0.3907 and do not get the crashes occuring while running the same sequence of events (heat --> sed script --> candle --> light). Hope this helps. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1942991&group_id=105970 ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
