Bugs item #1864685, was opened at 2008-01-05 12:31 Message generated for change (Comment added) made by micarls You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1864685&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: dark Group: None >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: Frank Eden (frankeden) Assigned to: Nobody/Anonymous (nobody) Summary: NullReferenceException due to rows in the AppSearch table Initial Comment: http://www.netspeed.com.au/frankeden/junk.zip I run dark against my MSI, and I get an exception. Ive tracked it down a bit, and I find that if I delete particular rows in the AppSearch table, I can get dark to work. Please download the "junk.msi" from the above URL that demonstrates the problem. Heres the output from dark C:\junk>dark junk.msi junk.wxs Microsoft (R) Windows Installer Xml Decompiler Version 3.0.3621.0 Copyright (C) Microsoft Corporation 2003. All rights reserved. junk.msi C:\junk\junk.msi : warning DARK1060 : The _InstallValidate table is being decomp ble. <snip> dark.exe : error DARK0001 : Object reference not set to an instance of an object Exception Type: System.NullReferenceException Stack Trace: at Microsoft.Tools.WindowsInstallerXml.Decompiler.FinalizeSearchTables(TableC at Microsoft.Tools.WindowsInstallerXml.Decompiler.FinalizeDecompile(TableColl at Microsoft.Tools.WindowsInstallerXml.Decompiler.Decompile(Output output) at Microsoft.Tools.WindowsInstallerXml.Tools.Dark.Run(String[] args) Unhandled Exception: System.NullReferenceException: Object reference not set to bject. at Microsoft.Tools.WindowsInstallerXml.Decompiler.FinalizeSearchTables(TableC at Microsoft.Tools.WindowsInstallerXml.Decompiler.FinalizeDecompile(TableColl at Microsoft.Tools.WindowsInstallerXml.Decompiler.Decompile(Output output) at Microsoft.Tools.WindowsInstallerXml.Tools.Dark.Run(String[] args) at Microsoft.Tools.WindowsInstallerXml.Tools.Dark.Main(String[] args) If I open the MSI with Orca, then delete a row from the AppSearch table LABELINKINSTALLDIR AppFile5 then all is well. I suspect that the problem might be somehow related to the fact that AppFile5 refers to a second row in the DrLocator table, as follows: AppFile5 AppFile5SigFile 2 AppFile5SigFile [ProgramFilesFolder] 2 ---------------------------------------------------------------------- >Comment By: Mike Carlson (micarls) Date: 2008-05-02 15:36 Message: Logged In: YES user_id=2057970 Originator: NO Part of this issue is fixed and the other part is a duplicate. Fixed two issues: dark no longer crashes or gives an error when decompiling this MSI, and the "name" attribute of the directory of ID "TargetDir" is now corrected to "SourceDir" (which is required by candle), to allow this part of the output to compile. Duplicate: The output dark now produces will fail to compile, because the decompiler is creating a directorysearch and a filesearch both as children of another directorysearch (which is invalid). This will be fixed in Bug #1273447 - in Bug #1273447 we'll be reworking much of the way this table is compiled and decompiled, to fix a number of issues related to complex hierarchies of various types of search elements. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1864685&group_id=105970 ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
