Jacob, now that the assignment agreement is done, can you send the pull
request for this feature?
On Wed, Oct 31, 2012 at 1:57 PM, Hoover, Jacob
<jacob.hoo...@greenheck.com>wrote:
> I’ve have a fork with my proposed changes at
> http://wix.codeplex.com/SourceControl/network/forks/jchoover/WixStdBA. I’ve
> defaulted the new attribute (EnableActionMessage) to none, but if you add
> the attribute to WixStandardBootstrapperApplication and specify it’s value
> of “text” you should get the same messages as if you were in a MSI and
> subscribed to the ActionText (
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa367515(v=vs.85).aspx)
> control
> event. If you specify the attribute as “data” you should get the same
> messages as if you were in a MSI and subscribed to the ActionData (
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa367462(v=vs.85).aspx)
> control
> event.****
>
> ** **
>
> I’ve tested this with my MSI with no UI included and the messages do still
> come across, so my previous concern about needing the UI and having a
> control subscribed were unfounded.****
>
> ** **
>
> Thanks,****
>
> Jacob****
>
> ** **
>
> *From:* Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
> *Sent:* Tuesday, October 30, 2012 4:35 PM
> *To:* os...@live.com; Windows Installer XML toolset developer mailing list
>
> *Subject:* Re: [WiX-devs] WixStdBA: Showing ActionData****
>
> ** **
>
> That’s what I went with in my fork, however now I think I need a new type.
> I think it would be a None/ActionText/ActionData to allow for more control
> over what the user wants.****
>
> ** **
>
> I’ll send an update once I make my tweaks in my fork.****
>
> ** **
>
> Jacob****
>
> ** **
>
> *From:* Blair Murri [mailto:os...@live.com]
> *Sent:* Tuesday, October 30, 2012 4:30 PM
> *To:* 'Windows Installer XML toolset developer mailing list'
> *Subject:* Re: [WiX-devs] WixStdBA: Showing ActionData****
>
> ** **
>
> I would say yes (new Boolean options should default to false, so use
> Enable instead of Suppress if it shouldn’t be enabled by default) and yes
> (which gives others the chance to review the changes before merging into
> the mainline).****
>
> ** **
>
> *From:* Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
> *Sent:* Saturday, October 27, 2012 9:30 AM
> *To:* Windows Installer XML toolset developer mailing list
> *Subject:* [WiX-devs] WixStdBA: Showing ActionData****
>
> ** **
>
> Looking for some feedback on a change I had proposed and am preparing to
> submit. I’ve tweaked WixStdBA to show MSI package ActionData on the
> Progress dialog. I think this feature should need to be explicitly turned
> on in order to maintain the existing behavior. As of now, I introduced a
> SuppressActionData attribute to the bal:WixStandardBootstrapperApplication
> element but it feels strange that all the other Suppress options default to
> False/No and this one defaults to True/Yes. I could change this around an
> make it an EnableActionData attribute.****
>
> ** **
>
> What would be the preferred attribute name and behavior? Is the process
> of submitting changes still creating a fork on Codeplex, submitting the
> changes, and issuing a pull request? ****
>
> ** **
>
> Thanks,****
>
> Jacob ****
>
> ** **
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_sfd2d_oct
> _______________________________________________
> WiX-devs mailing list
> WiX-devs@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wix-devs
>
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
