Ahh, I see it does just set installed without looking at the existing state (I
missed that on my first pass on the code and now explains the “Consideration”
question I added).
Thinking about it, why wouldn’t the support packages do the same? Oh, I see,
you want to have an extra package that may or may not apply... like only for
XP. Hmm.
Well, seems like the design of this feature should just take that into account.
Maybe the “yes|no” isn’t enough on the variable. Maybe there is an “always”,
“yes” and “no” option. Or something. Seems like the “always” should generally
not be necessary and, generally, not desired.
For example, what if you want one pre-req on Windows Vista and a different
pre-req on Windows 9? It seems like it should generally respect the install
condition with the option to force “always” install… and the old (er, current)
mechanism uses the “always” option.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Sean Hall [mailto:[email protected]]
Sent: Friday, May 16, 2014 4:37 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] WIP 4161 - Allow More Than One MBA Prerequisite
Thanks for responding. The main problem I see with your modifications is
backwards compatibility.
Believe it or not, the Prereq BA *always* installed the prereq package, it
didn't pay attention to its InstallCondition.
As a binder variable, you will still be forced to specify the
MbaPrereqPackageId and the url.
It doesn't really make sense to call it a support package if the goal is to
make all of the packages equal.
On Fri, May 16, 2014 at 6:24 PM, Rob Mensching
<[email protected]<mailto:[email protected]>> wrote:
I’ve bulked up the WIP a bit with my pull request at:
https://github.com/wixtoolset/site/pull/16
Sean, I’m curious if that aligns with how you were seeing the feature
implemented.
If so, I think that is the way to go. The original design was done for
expediency (you would be surprised how close we were to having no managed code
BA solution for a while).
I do think something like WIP #4161
(http://wixtoolset.org/development/wips/4161-allow-more-than-one-mbaprereq/ and
https://github.com/wixtoolset/site/pull/16) is ideal.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs
