A single commit? Uhh, that's rarely ideal. It's much better to see logical
commits to make it easier to review. Sean had a great example when he did the
thmutil updates in v4.
In this case, we've already reviewed this so it's less of an issue. You don't
need a new pull request. Just update the branch you sent the pull request from
and it should be good.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Tuesday, March 24, 2015 11:09 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] Pull request
Rob,
for https://github.com/wixtoolset/wix4/pull/80. I have a squashed branch
located at https://github.com/jchoover/wix4/tree/SelfUpdateTesting.v2; I could
kill the old pull request and submit the new one so it's a single commit. I
think I've addressed all the concerns/feedback that was provided. I've also
merged in all changes from upstream, so it should auto-merge for you.
Thanks,
Jacob
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
