On Fri 28.Aug'09 at 22:11:17 +0200, Johann Haarhoff wrote:
> This is the same patch I submitted back in February, but applied to the
> master branch of Carlos' git repo (http://repo.or.cz/w/wmaker-crm.git).
> Resubmitting on Carlos' request.
Thanks Johann!
I like the concept of your patch. The 50/50 separation is OK for most
of my use cases, and while we don't have a general Maximus-like
functionality I will keep using it.
I have already pushed it 'next' and will put it in 'master' soon, unless
someone opposes very strongly and if I happen to agree with the reason.
I have a small question though,
> --- a/src/actions.c
> +++ b/src/actions.c
> @@ -361,7 +361,6 @@ void wMaximizeWindow(WWindow * wwin, int directions)
> - changed_h = ((wwin->flags.maximized ^ directions) & MAX_HORIZONTAL);
> - changed_v = ((wwin->flags.maximized ^ directions) & MAX_VERTICAL);
> - shrink_h = (changed_h && (directions & MAX_HORIZONTAL) == 0);
> - shrink_v = (changed_v && (directions & MAX_VERTICAL) == 0);
> + directions &= (MAX_HORIZONTAL|MAX_VERTICAL|MAX_LEFTHALF|MAX_RIGHTHALF);
Why can you get rid of those lines,
> - } else if (shrink_h) {
> + } else if (directions & MAX_LEFTHALF) {
and use the above check instead? It seems a modification a bit unrelated
to the purpose of your patch, doesn't it?
I don't understand very well the logic behind the shrink_{h,v} check,
so that is why I ask.
--
To unsubscribe, send mail to [email protected].
