On Tue 1.Sep'09 at 9:22:37 +0200, Daniel Déchelotte wrote: > Here is a minor bugfix, for those of us who use an > autoraise/autocollapse dock. More details can be found in the attached > patch itself.
Thanks Daniel! > I hope it can be merge into stable. By that I mean, I hope it doesn't > break anything, and that it can be easily applied to your repo, Carlos. > Let me know if that's not the case. I will push it into 'master' soon, because your explanation is convincing and the fix is simple. There should not be any problems. > Regarding code style, is it on purpose that the code is now tabified? Yes, it is on purpose. I don't want to start a religious coding style war, but the one I use is the linux kernel's (Documentation/CodingStyle in the linux source). I learned C in that style. If C is not written like that I get distracted :-( As I am going to be reading a lot of wmaker source in the future, I converted it with 'indent -linux -l115', which enforces those rules (apart from the number of columns). 'indent' screwed up the "*" in the function declarations though. I think it is bug, because if the type is a knwon C type then it appears as function(int *number), but as function(WWindow * wwin) if otherwise. > Would you like my patch to use leading tabs as well, or can it be > "fixed" automatically when applying it? I fixed it manually (the "burden" of the chosen codingstyle is on me, but I will appreciate if you use tabs if there are more patches to submit :-) Thanks for the patch, Daniel! -- To unsubscribe, send mail to [email protected].
