The following comment has been added to this issue:
Author: lantz moore
Created: Fri, 21 Jan 2005 5:41 PM
Body:
err, by "instead" above, i meant that you might want to do a membership test
*or* make TemplateParser.mergeFiles a Set.
in addition to normalizing the Map access...
---------------------------------------------------------------------
View this comment:
http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1244?page=comments#action_15721
---------------------------------------------------------------------
View the issue:
http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1244
Here is an overview of the issue:
---------------------------------------------------------------------
Key: XDT-1244
Summary: GenerationManager mis-caching results from TemplateParser
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: XDoclet
Components:
Core
Versions:
1.2.1
1.2.2
Assignee: xdoclet-devel (Use for new issues)
Reporter: lantz moore
Created: Fri, 21 Jan 2005 5:27 PM
Updated: Fri, 21 Jan 2005 5:41 PM
Description:
i have a project that has several hundred hibernate entities. i noticed that a
rebuild after changing only a single source file took much longer than cleaning
and rebuilding from scratch.
after looking into it a bit, the code making use of the parserDb Map is using
inconsistent keys to access the map. this was causing the template to be
parsed repeatedly by the static TemplateTarget instance. since
TemplateParser.addMergeFile blindly adds entries, the mergeFile list was
growing with many duplicates.
after normalizing the access to parserDb, the rebuild was as speedy as expected.
you may want to add a membership check to TemplateParser.addMergeFile or make
mergeFiles a Set instead.
i'll attach a patch containing the parserDb access normalization in a moment.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/xdoclet/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
xdoclet-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
