tng 2002/11/28 09:37:47
Modified: c/src/xercesc/util XMLString.cpp
Log:
Performance: do not call XMLString::stringLen if just for the purpose of checking
zero-length string.
Revision Changes Path
1.12 +5 -13 xml-xerces/c/src/xercesc/util/XMLString.cpp
Index: XMLString.cpp
===================================================================
RCS file: /home/cvs/xml-xerces/c/src/xercesc/util/XMLString.cpp,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- XMLString.cpp 14 Nov 2002 22:15:31 -0000 1.11
+++ XMLString.cpp 28 Nov 2002 17:37:47 -0000 1.12
@@ -618,21 +618,17 @@
*/
bool XMLString::isValidNCName(const XMLCh* const name) {
- if (XMLString::stringLen(name) == 0
- || XMLString::indexOf(name, chColon) != -1) {
+ if ( !name || !*name )
return false;
- }
const XMLCh* tempName = name;
XMLCh firstChar = *tempName++;
if (!XMLReader::isXMLLetter(firstChar) && firstChar != chUnderscore) {
-
return false;
}
while(*tempName) {
-
if (*tempName == chColon || !XMLReader::isNameChar(*tempName++)) {
return false;
}
@@ -650,8 +646,7 @@
*/
bool XMLString::isValidName(const XMLCh* const name) {
- if (!name ||
- (XMLString::stringLen(name) == 0))
+ if (!name || !*name)
return false;
const XMLCh* tempName = name;
@@ -678,8 +673,7 @@
bool XMLString::isValidEncName(const XMLCh* const name)
{
- if ( ( !name) ||
- ( XMLString::stringLen(name) == 0 ))
+ if (!name || !*name)
return false;
const XMLCh* tempName = name;
@@ -1173,12 +1167,10 @@
int XMLString::patternMatch( const XMLCh* const toSearch
, const XMLCh* const pattern)
{
- if (!toSearch || !pattern )
+ if (!toSearch || !*toSearch || !pattern || !*pattern)
return -1;
const int patnLen = XMLString::stringLen(pattern);
- if ( !patnLen )
- return -1;
const XMLCh* srcPtr = toSearch;
const XMLCh* patnStart = toSearch;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
