On 09/06/2010 03:52 AM, Peter Hutterer wrote:
From: Thomas Hellstrom<[email protected]>
The drain_console() function will race with new keyboard events being added
by the hardware causing the server to lose keyboard events if the console fd
is used for input.
Only use the drain_console() when AllowEmptyInput is off which is the best
indicator we have for whether the keyboard driver will be used. This patch
will only fix the bug when hotplugging is disabled.
What we really need is a way to figure out either whether we're _not_ using
the keyboard driver (not predictable) or a way for the keyboard driver to
disable drain_console().
X.Org Bug 29969<http://bugs.freedesktop.org/show_bug.cgi?id=29969>
Signed-off-by: Thomas Hellstrom<[email protected]>
Reviewed-by: Peter Hutterer<[email protected]>
---
Thomas, I only added some comments to the commit message. Patch is good for
the stable servers, though for master I think we might need something better
integrated (see follow-up patch).
Looks fine!
/Thomas
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
