On Tue, Sep 07, 2010 at 01:31:20PM -0700, Alan Coopersmith wrote: > Shouldn't this just go into an internal .h instead of trying to keep > definitions > in sync between multiple *.c files? > > -alan- > > Rémi Cardona wrote: > > src/extutil.c has _X_HIDDEN while src/Xge.c didn't. This apparently went > > unnoticed by most compilers for a while, but not on Gentoo-prefix/amd64 > > where this issue breaks the build. > > > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=29958 > > > > Signed-off-by: Ivan Jager <[email protected]> > > Reviewed-by: Rémi Cardona <[email protected]> > > --- > > > > Could I get an extra pair of eyes to ACK this before committing?
I agree with Alan that a header file may be nicer, though we currently need this for a single function definition only. As a temporary fix for the bug above: Acked-by: Peter Hutterer <[email protected]> Cheers, Peter > > > > Thanks, > > > > Rémi > > > > src/Xge.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/Xge.c b/src/Xge.c > > index 0655e00..2e25894 100644 > > --- a/src/Xge.c > > +++ b/src/Xge.c > > @@ -291,7 +291,7 @@ _xgeEventToWire(Display* dpy, XEvent* re, xEvent* event) > > /* > > * Extensions need to register callbacks for their events. > > */ > > -Bool > > +_X_HIDDEN Bool > > xgeExtRegister(Display* dpy, int offset, XExtensionHooks* callbacks) > > { > > XGEExtNode* newExt; > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
