On Mon, Nov 8, 2010 at 10:06:31 +1000, Peter Hutterer wrote: [...] > +static int > +remove_master(ClientPtr client, xXIRemoveMasterInfo *r, > + int flags[MAXDEVICES]) > +{ > + DeviceIntPtr ptr, keybd, XTestptr, XTestkeybd; > + int rc = Success; > + > + if (r->return_mode != XIAttachToMaster && > + r->return_mode != XIFloating) > + return BadValue; > + Probably for a followup patch, but set client->errorValue to r->return_mode here? There's a couple other places around there that might want to set errorValue as well, I think.
For the patch itself, Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel