Hello folks, based on recent discussion in gitlab (*1) I'm wondering whether we should explicitly mark non-exported functions of the Xserver as _X_HIDDEN or _X_INTERNAL.
It seems that anything not explicitly exported currently defaults to hidden. OTOH, _X_INTERNAL - at least on gcc - would allow the compiler some more opimizations (*2), since it's known that those funcs can't be called from another module (not even via func pointers). What's your opinion ? --mtx *1) https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1273#note_2272140 *2) https://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Function-Attributes.html#:~:text=Unless%20otherwise%20specified%20by%20the,referenced%20indirectly%20via%20function%20pointers. -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287
