Pat Kane schrieb: > In the original code if 'i' is equal to 10 then the line > (void) memmove((char*)par, (char*)params, i * sizeof(String) ); > moves ten things, which is okay. > > The next line: > bzero( &par[i], (10-i) * sizeof(String) ); > moves zero things to a bad address, which is probably okay, > but I bet some code checker would complain. > > The code is very ugly. >
yes, i can fix that too but i still feel that i=10 bzero( &par[i], (10-i) * sizeof(String) ); setting the limit to i=9 would fix that. most maintainers prefer 1 fix 1 patch, i can send a revisited patch re, wh _______________________________________________ xorg@lists.freedesktop.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.freedesktop.org/mailman/listinfo/xorg Your subscription address: arch...@mail-archive.com