On 2021-02-05 Brett Okken wrote: > On Fri, Feb 5, 2021 at 11:07 AM Lasse Collin > <lasse.col...@tukaani.org> wrote: > > Also, does it really help to unroll the loop? With 8191-byte > > buffers I see no significant difference (in a quick > > not-very-accurate test) if the switch-statement is replaced with a > > while-loop. > > The differences are pretty minimal. My observation was switch a bit > faster than for loop, which was a bit faster than a while loop. But > the differences in averages were less than the confidence interval for > the given tests.
OK, smaller code wins then. > > With these two changes the code becomes functionally identical to > > the version I posted with the name "Modified slicing-by-4". Is that > > an OK version to commit? > > Yes. OK. > > Is the following fine to you as the file header? Your email address > > can be omitted if you prefer that. I will mention in the commit > > message that you adapted the code from XZ Utils and benchmarked it. > > > > /* > > * CRC64 > > * > > * Authors: Brett Okken <EMAIL> > > * Lasse Collin <EMAIL> > > * > > * This file has been put into the public domain. > > * You can do whatever you want with this file. > > */ > > That is fine. You can include my e-mail. OK. :-) I have committed it. Thank you! The LZDecoder changes I may still look at before the next release. Then I will go back to the XZ Utils code. -- Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
