Florian Festi wrote:
Tim Lauridsen wrote:
Jeremy Katz wrote:
On Mon, 2007-08-20 at 15:41 +0200, Tim Lauridsen wrote:
After adding prepareTransaction & helpers to YumBase a YumBaseError
exception is raised if any thing goes wrong.
but i would be nice to see, if it was Download or GPGCheck or
TestTransaction there went wrong.
So i have created a patch with some extra Yum Exception and make the
different step cast a custom exception.
Just want to know if the naming look sane, before committing.

Naming seems fine -- it's worth making the new exceptions distinct
classes rather than equal, though, so that you can actually distinguish
between them when they're raised
Yes, offcause the make a lot of sense :-) .
New patch added.

Hmm, why do all these exception classes have a __init__ method that (semantically) equals that of their base class...
We could save a lot of lines by reducing the class bodies to just "pass"
Never thought of that,  i will remove the __init__ methods.

Tim
_______________________________________________
Yum-devel mailing list
Yum-devel@linux.duke.edu
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel

Reply via email to