----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/671/ -----------------------------------------------------------
Review request for zetacomponents. Summary ------- Used iconv/mbstring to get multibyte safe string functions. This addresses bug ZETACOMP-15. https://issues.apache.org/jira/browse/ZETACOMP-15 Diffs ----- trunk/Template/src/functions/string_code.php 1097375 trunk/Template/src/functions/string_functions.php 1097375 trunk/Template/src/structs/lower_to_upper.php PRE-CREATION trunk/Template/src/structs/upper_to_lower.php PRE-CREATION trunk/Template/src/template_autoload.php 1097375 trunk/Template/src/unicode/generate_unicode_tables.php PRE-CREATION trunk/Template/tests/regression_test.php 1097375 trunk/Template/tests/regression_tests/functions/correct/string_functions.in 1097375 trunk/Template/tests/regression_tests/functions/correct/string_functions.out 1097375 trunk/Template/tests/string_function_test.php PRE-CREATION trunk/Template/tests/suite.php 1097375 Diff: https://reviews.apache.org/r/671/diff Testing ------- Ran the unit test suite : PHP 5.3.2 (cli) (built: Apr 5 2011 21:42:43) Copyright (c) 1997-2010 The PHP Group Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies with Xdebug v2.1.0, Copyright (c) 2002-2010, by Derick Rethans PHPUnit 3.5.10 by Sebastian Bergmann. Zeta Components: Template: ezcTemplateRegressionTest: ................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... ezcTemplateFileExceptionTest: ..... ezcTemplateVariableCollectionTest: .. ezcTemplateValidationItemTest: .. ezcTemplateOutputContextTest: . ezcTemplateXhtmlContextTest: . ezcTemplateCursorTest: ........ ezcTemplateWhitespaceRemovalTest: ..... ezcTemplateTextBlockElementTest: . ezcTemplateOperatorTest: ... ezcTemplateCodeElementsTest: ........ ezcTemplateSourceCodeTest: ................ ezcTemplateCompiledCodeTest: ......... ezcTemplateConfigurationTest: .... ezcTemplateCacheTest: ........................................... ezcTemplateCacheManagerTest: SSSSS ezcTemplateTest: ..................... ezcTemplateLocaleTest: .. ezcStringFunctionTest: ............. Time: 01:50, Memory: 27.75Mb OK, but incomplete or skipped tests! Tests: 1064, Assertions: 2081, Skipped: 5. Thanks, Jérôme