[ https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934946#action_12934946 ]
Benjamin Reed commented on ZOOKEEPER-836: ----------------------------------------- it seems like overkill to have a class to just parse a hostlist. wouldn't you want put that parsing in the class that actually manages the list? we should not be passing around a list of resolved addresses, since those addresses and the list themselves can change. (this is what i mentioned earlier.) instead hostset should take care of resolving and managing the list of resolved addresses. i guess we can do that as a separate patch. > hostlist as string > ------------------ > > Key: ZOOKEEPER-836 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836 > Project: Zookeeper > Issue Type: Sub-task > Components: java client > Affects Versions: 3.3.1 > Reporter: Patrick Datko > Assignee: Thomas Koch > Attachments: ZOOKEEPER-836.patch > > > The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of > not doing (too much) work in a ctor. Instead the ClientCnxn should receive an > object of class "HostSet". HostSet could then be instantiated e.g. with a > comma separated string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.