Hello, Joe. A couple of small comments:
AffineTransformOp.java: Could you please split a long line #241 ClipboardTransferable.java: You can safely remove the DataTransferer.getInstance in this place. The DataTransferer is a singleton and it's already created by this time. SunDragSourceContextPeer.java: same here, you can safely remove the getInstance D3DDrawImage.java: you've mistyped the copyright update. D3DSurfaceDataProxy.java: Why did you choose to suppress a warning here? the getD3DDevice is just a getter, it does not allocate new object and has no side effects.. With best regards. Petr. On 17.01.2014, at 10:55, Joe Darcy <joe.da...@oracle.com> wrote: > Hello, > > Please view my proposed fix for > > JDK-8032047: Fix static lint warnings in client libraries > http://cr.openjdk.java.net/~darcy/8032047.0/ > > Mostly this fix consisted of just replacing a variable name with the class > name mentioned by javac in the warning message. In a few cases where the > expression allocated a new object, I choose to just suppress the warning > since I didn't feel motivated to analyze the possible side-effects of the > allocation. > > Thanks, > > -Joe >
