Hello,
An update, good news / bad news from the jprt job; the jprt job failed,
but there was only a single missed instance of a static warning in the
sources to the jdk repo:
src\windows\classes\sun\java2d\d3d\D3DSurfaceData.java:741: warning:
[static] static method should be qualified by type name, D3DRenderQueue,
instead of by an expression
if (rq.isRenderQueueThread()) {
^
I plan to fix it accordingly:
@@ -738,7 +738,7 @@
D3DRenderQueue rq = D3DRenderQueue.getInstance();
// swapBuffers can be called from the toolkit thread by swing, we
// should detect this and prevent the deadlocks
- if (rq.isRenderQueueThread()) {
+ if (D3DRenderQueue.isRenderQueueThread()) {
if (!rq.tryLock()) {
// if we could not obtain the lock, repaint the area
// that was supposed to be swapped, and no-op this swap
Given that the builds were otherwise successful, I plan to get a fix for
JDK-8032048: Add static lint warning to build of jdk repository
reviewed and then push JDK-8032047 and JDK-8032048 together in a single
jprt job.
Thanks,
-Joe
On 01/17/2014 02:50 PM, Joe Darcy wrote:
Hello,
I've had a jprt job submitted to make sure that aren't any
cross-platform build issues (and to flush out any other static
warnings in the code base).
If the jprt is successful, I'll push the changes proposed so far.
Thanks Petr and Sergey for the reviews,
-Joe
On 01/17/2014 02:12 PM, Petr Pchelko wrote:
Hello, Joe.
The final version still looks good.
With best regards. Petr.
18 янв. 2014 г., в 1:47 до полудня, Sergey Bylokhov
<sergey.bylok...@oracle.com> написал(а):
Hello, Joe.
This version looks good to me too.
