Hi Volker, I've updated the patch by dropping the those fonts configurations from $JRE_LIB_FONTS directory. The change is based on the SAP version, current change is primarily adding support for CJK fonts, pls review.
http://cr.openjdk.java.net/~luchsh/JDK-8034218.v2/ Thanks Jonathan On Tue, May 13, 2014 at 5:25 PM, Volker Simonis <volker.simo...@gmail.com>wrote: > Hi Jonathan, > > from all fontconfig files in make/data/fontconfig, > solaris.fontconfig.properties is the only file which contains a single > line referring to $JRE_LIB_FONTS. This is obviously a first-day bug > which should be fixed. > > It simply makes no sense to define font files and default fonts with > references to files which won't be in a JDK for sure. Again, if you > could convince IBM to donate the corresponding fonts to the OpenJDK > that would be great. Otherwise these entries should be dropped from > the fontconfig files. > > Thank you and best regards, > Volker > > > On Tue, May 13, 2014 at 4:06 AM, Jonathan Lu <luc...@linux.vnet.ibm.com> > wrote: > > Hi Phil, Volker, > > > > Thanks for your comments, but I noticed that JRE_LIB_FONTS has been > referred > > by the solaris fontconfig file, > > > > jdk/make/data/fontconfig/solaris.fontconfig.properties > > > > So I'm wondering if we can do this in the same way as Solaris platform. > > > > > > Thanks > > Jonathan > > > > > > > > On Tue, May 13, 2014 at 12:47 AM, Phil Race <philip.r...@oracle.com> > wrote: > >> > >> removed awt-dev ... > >> > >> > >> > I don't think we should reference the fonts > >> > under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.properties > >> > >> Volker is correct on this point. > >> > >> Since OpenJDK can't ship those fonts we made sure they were never used > >> in any openjdk fontconfig file. > >> > >> -phil. > >> > >> > >> > >> On 05/12/2014 09:42 AM, Phil Race wrote: > >>> > >>> All, > >>> > >>> If you want to continue this discussion i should be restarted on 2d-dev > >>> and awt-dev removed. AWT has nothing to do with the fonts .. > >>> I've fixed the bug sub-cat. > >>> > >>> -phil. > >>> > >>> On 05/12/2014 09:06 AM, Volker Simonis wrote: > >>>> > >>>> Hi Jonathan, > >>>> > >>>> thanks for submitting this patch. > >>>> > >>>> Overall it looks good, but I don't think we should reference the fonts > >>>> under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.properties > >>>> (at least not until IBM will not also contribute the corresponding > >>>> fonts :) > >>>> > >>>> I would also find it helpful to keep a reworked version of the > comment: > >>>> > >>>> 27 # Minimal version for AIX using the standard Latin Type1 Fonts > >>>> from the > >>>> 28 # package X11.fnt.iso_T1. These fonts are installed by default > >>>> into > >>>> 29 # "/usr/lpp/X11/lib/X11/fonts/Type1" and sym-linked to > >>>> "/usr/lib/X11/fonts/Type1" > >>>> > >>>> which mentions which AIX packages provide the other referenced font > >>>> files. > >>>> > >>>> Thank you and best regards, > >>>> Volker > >>>> > >>>> > >>>> > >>>> On Mon, May 12, 2014 at 12:37 PM, Jonathan Lu > >>>> <luc...@linux.vnet.ibm.com> wrote: > >>>>> > >>>>> Hi awt-dev, > >>>>> > >>>>> Please review the fix for issue: > >>>>> https://bugs.openjdk.java.net/browse/JDK-8034218 > >>>>> > >>>>> The changes are placed at > >>>>> http://cr.openjdk.java.net/~luchsh/JDK-8034218/ > >>>>> > >>>>> This patch is trying to provide a better fonctconfig.properties file > >>>>> for AIX > >>>>> platform, > >>>>> which contains support for more languages, like CJK. > >>>>> > >>>>> > >>>>> Thanks > >>>>> Jonathan > >>>>> > >>>>> > >>> > >> > > >
