One more review, please ! I would like pushing this patch asap: it fixes a SEGFAULT.
PS: the new generic ReentrantContext providers may benefit to other java2d cached data... Regards, Laurent Le 12 févr. 2016 09:46, "Laurent Bourgès" <[email protected]> a écrit : > Jim & Phil, > > > 2016-02-11 23:20 GMT+01:00 Jim Graham <[email protected]>: > >> It all looks great. The comments are fine for internal documentation, >> but here is a suggestion for the initial comment on a couple of the >> Provider classes. I don't need to review the changes to comments. >> > > Thanks Jim for your carefull reviews and your suggestions: I integrated > your changes to javadoc with care. > > FYI I always use the following command to remove redundant white spaces: > find . -type f -name '*.java' -exec sed --in-place 's/[[:space:]]\+$//' {} > \; > > To summarize, I can count on jim's review but another one is missing. > > Phil, do you approve too ? > > Regards, > Laurent >
