Hi Laurent,
I swear I thought I remember asking this before and getting an answer,
but I can't find it.
RenderContext line 49 - should that be "!= HARD" so that you keep a hard
reference for SOFT as well?
Also, I just noticed a typo in the sample code in
ReentrantContextProvider, shouldn't the constructor in the newContext()
method be "new ReentrantContextImpl()"? (TileState probably came from
cutting and pasting from AAShapePipe.)
...jim
On 2/18/2016 12:41 AM, Laurent Bourgès wrote:
Phil & Jim,
Here is an updated webrev including jim's changes to comments:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8148886.5/
Hope it is ready to push,
Regards,
Laurent
2016-02-12 9:46 GMT+01:00 Laurent Bourgès <bourges.laur...@gmail.com
<mailto:bourges.laur...@gmail.com>>:
Jim & Phil,
2016-02-11 23:20 GMT+01:00 Jim Graham <james.gra...@oracle.com
<mailto:james.gra...@oracle.com>>:
It all looks great. The comments are fine for internal
documentation, but here is a suggestion for the initial comment
on a couple of the Provider classes. I don't need to review the
changes to comments.
Thanks Jim for your carefull reviews and your suggestions: I
integrated your changes to javadoc with care.
FYI I always use the following command to remove redundant white spaces:
find . -type f -name '*.java' -exec sed --in-place
's/[[:space:]]\+$//' {} \;
To summarize, I can count on jim's review but another one is missing.
Phil, do you approve too ?
Regards,
Laurent
