It is not always clear to me what warning is being suppressed and why you have
chosen a particular solution/action
this next one looks like it might introduce an unused variable warning.
What was it solving ? That the code was not checking a return value ?
size_t bytesWritten = write ( AWT_WRITEPIPE, &wakeUp_char, 1 ); //bytesWritten
is unused
Isn't the compiler's point here that you *should* be doing something with the
result?
Not just ignoring it differently ...
-----
and this one ? I want Semyon to comment on what this code is trying to do
in its original form since it was added for GTK3.
@@ -1989,11 +2029,7 @@
static guint8 recode_color(gdouble channel)
{
guint16 result = (guint16)(channel * 65535);
- if (result < 0) {
- result = 0;
- } else if (result > 65535) {
- result = 65535;
- }
+
return (guint8)( result >> 8);
}
-----
-phil.
On 06/23/2016 12:09 AM, Ajit Ghaisas wrote:
Hi,
Bug :
https://bugs.openjdk.java.net/browse/JDK-8074824
(Resolve disabled warnings for libawt_xawt)
As part of fixing this bug, I have -
1. Fixed warnings in source code after removing blanket warning
suppressions from makefile.
2. In case the warning fix is not possible, converted blanket warning
suppression for this library to suppression of warnings for individual files.
3. Added comments in makefile for the warning suppression that cannot be
fixed.
One type of gcc warning 'deprecated-declarations' will be fixed separately
(as part of JDK-8160146)
I have built the changes successfully on all supported platforms.
Webrev :
http://cr.openjdk.java.net/~aghaisas/8074824/webrev.00/
Request you to review.
Regards,
Ajit
