Hi All,

In continuation with the below mail, the issue is "collate" option is not checked for linux.

Bug: https://bugs.openjdk.java.net/browse/JDK-8170352

webrev: http://cr.openjdk.java.net/~psadhukhan/8170352/webrev.00/

Proposed fix is to disable collate option for linux in printer dialog.

Regards
Prasanta
On 12/8/2016 4:23 PM, Prasanta Sadhukhan wrote:

Hi Phil,

I was investigating JDK-8170352: The collate option is not checked and I found that CUPS does not report collate as supported attribute.

It is removed from printRequestAttrib [http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l167] so we do not look for collate-supported attribute in CUPS. Infact, getAttMap does not have any "collate-supported" attribute too!! Also, this code [http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1062] has been added [for 8016737]
to remove SheetCollate from supported attributes.

In light of this, I think we should disabled collate option from our print dialog even for Toolkit based PrintJob. It seems, from this code
http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1251
it is enabled if we specify in testcase
/job.setDefaultSelection(JobAttributes.DefaultSelectionType.SELECTION); /in which case isAWT set to true. even though selection is determined by attribute support [http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1320]

I could not find why it is hardcoded to setEnabled(true) for "Selection". Do you know? mercurial history shows that line from jdk7 and I could not find previous history. I think there also, we should check for "scSupported" to enable sheetcollate? Anyways, "Selection" option is not there in linux.
Please let me know your views.

Regards
Prasanta

Reply via email to