Hello Brian
Thank you for your time & feedback.
I 've made the corrections as you have suggested.
. Spaces have been added around "-" sign in PNGImageReader
. All multi line comments have been corrected with verbiage starting in 2nd
line.
On PNGImageWriter writing Creation Time in text chunks
. When writing the text chunks to the output stream, PNGImageWriter uses
the data in the ArrayList(s) that correspond to different text chunks.
. By ensuring that every update to Standard/ Document/ ImageCreationTime is
reflected on the ArrayList of the last decoded text chunk with Creation Time,
we also ensure that Creation Time would be written to output by the
PNGImageWriter. Hence no additional changes will be required in PNGImageWriter
file.
The updated code can be reviewed at:
http://cr.openjdk.java.net/~pnarayanan/8164971/webrev.03/
Kindly review the changes at your convenience & provide your feedback.
Thank you for your time in review
Have a good day
Prahalad N.
----- Original Message -----
From: Brian Burkhalter
Sent: Saturday, August 19, 2017 12:57 AM
To: Prahalad Kumar Narayanan
Cc: Jayathirth D V; [email protected]
Subject: Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not
handle ImageCreationTime
Hello Prahalad,
This review is with respect to [1]. Picky comments:
PNGImageReader:
479, 570, 667: Add space around the "-" signs.
741, 752, 757 and in other files: In general, comments starting with "/*"
should be blank after the "/*" with the actual verbiage starting on the next
line.
What about the PNG ImageWriter? The description in the issue [2] implies that
the the ImageCreationTime should be used to set the Creation Time in the text
chunk(s). Or is this already happening?
Thanks,
Brian
[1] http://cr.openjdk.java.net/~pnarayanan/8164971/webrev.02/
[2] https://bugs.openjdk.java.net/browse/JDK-8164971
On Jul 20, 2017, at 7:27 AM, Prahalad Kumar Narayanan
<[email protected]> wrote:
First, Thanks to Brian and Jay for their time in review & feedback.
. I 've addressed the review suggestions and the updated code is available
for review.
. Webrev Link: http://cr.openjdk.java.net/~pnarayanan/8164971/webrev.01/
