Hello Prahalad, I think this looks OK. I wonder however whether it might not hurt to add a “round trip” sub-test which would write out the image containing the CreationTime and then read it back in and verify that the time was actually written to the image. I think this is optional so if you want to go ahead with the patch as-is that is fine.
Thanks, Brian On Aug 24, 2017, at 2:46 AM, Prahalad Kumar Narayanan <prahalad.kumar.naraya...@oracle.com> wrote: > I 've made the corrections as you have suggested. > . Spaces have been added around "-" sign in PNGImageReader > . All multi line comments have been corrected with verbiage starting in > 2nd line. > > On PNGImageWriter writing Creation Time in text chunks > . When writing the text chunks to the output stream, PNGImageWriter uses > the data in the ArrayList(s) that correspond to different text chunks. > . By ensuring that every update to Standard/ Document/ ImageCreationTime > is reflected on the ArrayList of the last decoded text chunk with Creation > Time, we also ensure that Creation Time would be written to output by the > PNGImageWriter. Hence no additional changes will be required in > PNGImageWriter file. > > The updated code can be reviewed at: > http://cr.openjdk.java.net/~pnarayanan/8164971/webrev.03/ > > Kindly review the changes at your convenience & provide your feedback.
