This seems like a bit of a workaround to insert what you would like to
be the
current end result of javadoc processing instead of letting javadoc
process it.
If the output format of @since tags changed you would not get the
benefit of it.
And after reading the linked bug reports which have comments post-dating
this
review they seem to be saying what was done here is not legal for javadoc.
So what is the correct way to do this ? Probably not to wrap main around
the javadoc tag ?
-phil.
On 12/5/18 3:48 AM, Jayathirth D V wrote:
Hello All,
Please review the following fix in JDK12:
Bug : https://bugs.openjdk.java.net/browse/JDK-8213050
Webrev : http://cr.openjdk.java.net/~jdv/8213050/webrev.00/
Issue : Markup corrector tidy is throwing issues in files
bmp_metadata.html, wbmp_metadata.html & tiff_metadata.html.
Root cause : Under JDK-8199150
<https://bugs.openjdk.java.net/browse/JDK-8199150> we have added
<main> tags from accessibility perspective. Above mentioned 3 files
also have @since tag just before </main>. When we use “make docs”, it
is messing up with </main> tag and simpleTagLabel and we are creating
corrupted Javadoc file. This may be a Javadoc tool issue, I have
raised separate bug JDK-8214855
<https://bugs.openjdk.java.net/browse/JDK-8214855> for the same.
Solution : Since we are looking for a fix of this issue in JDK 12, I
have explicitly added proper html data (which was generated before
JDK-8199150 <https://bugs.openjdk.java.net/browse/JDK-8199150> by the
tool) in 3 html files.
Thanks,
Jay
