On 2/11/19 1:44 AM, Alexey Ivanov wrote:
Hi Phil,
On 08/02/2019 21:02, Phil Race wrote:
can you add
@key headful
to all these tests ?
Yes, I can if you think it's required.
Yes. I think it is required.
However, I think we should keep them without @key headful so that
they're run more regularly. BufferedImage can be used in headless
environment.
I think that the isHeadless() test was not catching the case when
some VM is in use
that really should not have run the test.
The fix is still valid but I think we should have this too. This way
jtreg won't bother even
running the test if there's no head.
Isn't isHeadless() used by jtreg itself?
Not so far as I know.
These tests seem to have failed only in Windows where there's no true
headless environment. Recent versions of Windows Server allow
installing the OS without support for desktop environment, it could be
the reason why we see the limited IndexColorModel.
I was thinking whether I shall add a diagnostic message for skipping
VolatileImage when IndexColorModel is in effect…
sure.
-phil.
Regards,
Alexey
-phil.
On 2/8/19 12:13 PM, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13:
bugs:
https://bugs.openjdk.java.net/browse/JDK-8218682
https://bugs.openjdk.java.net/browse/JDK-8198411
webrev:
http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/
Description:
The updated DashOffset test proved to fail in mach5.
It passed BufferedImage test and then failed VolatileImage test.
VolatileImage had different colours instead of the expected white,
blue and green.
Root cause:
The host uses IndexColorModel; the image uses the closest colour.
Thus the colours do not match.
It's also the reason why DashScaleMinWidth.java and
DashZeroWidth.java fail in mach5.
Fix:
Skip testing VolatileImage where default graphics configuration uses
IndexColorModel.
I'm removing DashScaleMinWidth.java and DashZeroWidth.java from
ProblemList.txt as the tests pass now.
Regards,
Alexey
