Thanks! Cheers, Mario
On Tue 14. Jan 2020 at 22:58, Alexander Zuev <alexander.z...@oracle.com> wrote: > Hi Phil, Clemens, > > both code change and test looks fine to me. > > /Alex > > On 1/14/20 12:33, Phil Race wrote: > > Here's your webrev with a jtreg compliant test added : > > http://cr.openjdk.java.net/~prr/8235904/ > > > > I verified the test behaves properly under jtreg - > > before the fix jtreg kills it on time out > > after the fix it finishes quickly and successfully > > > > Outside of jtreg it also exits properly although jtreg is the normal > > way to run it. > > > > This is all +1 from me but I think someone else should sign off on > > this too since I > > don't want to self-review the test. > > > > -phil. > > > > On 1/12/20 11:54 AM, Phil Race wrote: > >> Hi Clemens, > >> > >> That needs reworking in location as well as adding jtreg boiler plate > >> and legal notice. Also there are code changes required to be a well > >> behaved test. I need to sit in front of a headful Linux system to > >> test those so I will have to follow up on this (hopefully) tomorrow. > >> > >> -Phil. > >> > >>> On Jan 11, 2020, at 12:40 PM, Clemens Eisserer > >>> <linuxhi...@gmail.com> wrote: > >>> > >>> Hi Phil, > >>> > >>>> Is there a regression test ? > >>>> I don't see a noreg- label. > >>> Sorry I forgot to mention, the regression test is in the "main" > >>> directory of the bugfix: > >>> http://cr.openjdk.java.net/~ceisserer/8235904/ > >>> > >>> Thanks and best regards, Clemens > > > > -- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF Java Champion - Blog: http://neugens.wordpress.com - Twitter: @neugens Proud GNU Classpath developer: http://www.classpath.org/ OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/
