Hello Christoph, looks good to me .

Some minor nits :

SunFontManager.java


  *   Why did you add the initialization ?

954         PhysicalFont physicalFont = null;



  *   Copyright headers of the java files should be adjusted to 2020


Thanks, Matthias


From: Langer, Christoph
Sent: Freitag, 24. Januar 2020 09:52
To: Phil Race <philip.r...@oracle.com<mailto:philip.r...@oracle.com>>; 
2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net>
Cc: Ichiroh Takiguchi 
<taki...@linux.vnet.ibm.com<mailto:taki...@linux.vnet.ibm.com>>
Subject: RE: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when 
fontconfig.properties was used

Ping…

http://cr.openjdk.java.net/~clanger/webrevs/8221741.1/

May I submit this fix to jdk-client? Or what would you want me to change to get 
it accepted?

This is running for weeks now in our CI infra (on various systems and 
platforms) and showing no problems…

Thanks
Christoph

Reply via email to