On Tue, 27 Oct 2020 07:50:30 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Please review a manual printing test failure where the instructions is not 
>> matching the printing result 
>> as the labels which are present in the test instruction frame is cut off in 
>> printed result due to margin not being accounted for, 
>> as the labels in the test instruction is fully left aligned starting from 0.
>> Fixed by adding some spaces before labels and 
>> for other labels drawn through drawChars, modified to draw the labels from 
>> coordinate 20 instead of 0 to allow labels being printed in the paper and 
>> not get cutoff by margin.
>> Also, the Print instruction is brought to top and 1st label is brought to 
>> bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to 
>> account for top margin cutoff, brought it lower so that those labels does 
>> not get cut off.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Translate the graphics context origin to x,y coordinate of paper's 
> imageable area

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/780

Reply via email to