On Tue, 6 Apr 2021 20:39:04 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> I added a blank line between the condition and the body.
>> Does it look good? @mrserb, @jayathirthrao
>
> [Code Conventions for 
> Java](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#248)
>  say, “Line wrapping for `if` statements should generally use the 8-space 
> rule, since conventional (4 space) indentation makes seeing the body 
> difficult.” (It's the second to last block on the page.)

If we are adding a new line, then I think we should need to add at l129, l138 
otherwise it will look odd doing it at one place only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3151

Reply via email to