Dan Diephouse wrote: > [snip] > Inside the spring module that I created, they're marked as required. This > has the benefit of when people declare abdera-spring in their maven build it > pulls in the dependencies automatically. > > However, at the moment its probably not that big of deal. I'll change the > patch to put it in the server module with an optional dependency. In the > future though, I may bring this issue back up again though as there may be > both client & server related spring code. In which case I'd want to share > stuff like AbstractSingleBeanDefinitionParser between the two modules. Which > would imply the need for a separate spring module. >
I'm not deadset against a separate module if that makes the most sense and it does make sense to bundle the client and server spring code together. It's easy to make it optional in ant using the same logic we use for the Security module (e.g. the user has to turn on an environment variable to build the security stuff)... Ok, I think I just convinced myself to change my mind ;-) ... a separate spring module would likely be the best way to go. > [snip] > The xml handling part of it it really orthogonal to the spring > AbderaServlet. The XML handling part is for configuring a ServiceContext. > The HttpRequestHandlerServlet approach, as I understand, it can't really > replace this - it could only replace the AbderaServlet which is pretty > simple itself. Does that make sense or am I off in my understanding of what > you're describing? > Btw, can you please rename this to SpringAbderaServlet to avoid confusion with the existing AbderaServlet? - James
