Re: Commit: change getNative8BitEncoding to return UTF-8 on linux

[Christian Biesinger]

Andrew Dunbar wrote:

 --- Christian Biesinger <[EMAIL PROTECTED]> wrote:

Changed
xap_UnixEncodingManager::getNative8BitEncoding to
return UTF-8.

This is absolutely the *wrong* solution.
Native8BitEncoding is *specifically* *always* a non-
Unicode encoding.

Hm, sure, I can change the caller as well... I actually intended to do that, but dom told me to change that function.

So there are two other ways of fixing that:
o) Change UT_wctomb's default constructor to not use getNative8BitEncoding but XAP_App::getDefaultEncoding or
o) Change AP_DiskStringSet::setValue to pass XAP_App::getDefaultEncoding to UT_wctomb's constructor.

which one is better?

--
Fiat iustitia, pereat mundus.